Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update actions/setup-python action to v5 #421

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 18, 2023

Mend Renovate

This PR contains the following updates:

Package Type Update Change
actions/setup-python action major v2 -> v5
actions/setup-python action major v3 -> v5

Release Notes

actions/setup-python (actions/setup-python)

v5

Compare Source

v4

Compare Source

v3

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Contributor

richardli1598 commented Dec 18, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of changed source code files in this PR.


There are a couple of issues to address within this patch:

  1. Version Mismatch for actions/checkout:
    The version of actions/checkout used in kubespider-style.yaml is v3 whereas in kubespider-unittest.yaml it is v2. If the intention is to keep all actions up-to-date, actions/checkout should be consistent across all workflow files. Therefore, in kubespider-unittest.yaml, it should be updated to v3 to match kubespider-style.yaml, assuming v3 is indeed the latest or the desired version to use.

  2. Hardcoded Python Version in kubespider-unittest.yaml:
    The kubespider-unittest.yaml file specifically hardcodes Python 3.10 as the version. After the update of actions/setup-python to v5, all Python versions should ideally be specified using a matrix strategy for consistency and to ensure flexibility in testing against multiple Python versions, similar to how it's done in kubespider-style.yaml. Consider using a strategy block with a matrix if testing multiple versions of Python is desired.

  3. Consistent Use of Quotation Marks:
    In kubespider-style.yaml, the Python version is specified without quotation marks (likely relying on YAML's type coercion), whereas in kubespider-unittest.yaml, it is specified with quotation marks around the version number. It's best practice to be consistent with how values are specified in your YAML configuration. Decide on whether to use the quotation marks and apply it uniformly across both files.

It's important to ensure the rest of the workflow files and their corresponding steps are compatible with the updated version of actions/setup-python to prevent any unforeseen issues. Additionally, thoroughly check the changelog or release notes for actions/setup-python@v5 to verify if there are any breaking changes or new configurations that must be addressed when migrating from an older version to the new one.

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for kubespider ready!

Name Link
🔨 Latest commit d10d830
🔍 Latest deploy log https://app.netlify.com/sites/kubespider/deploys/65815f4260b0d300081873d0
😎 Deploy Preview https://deploy-preview-421--kubespider.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@renovate renovate bot force-pushed the renovate/actions-setup-python-5.x branch from 670c016 to 185bea2 Compare December 19, 2023 09:10
@renovate renovate bot force-pushed the renovate/actions-setup-python-5.x branch from 185bea2 to d10d830 Compare December 19, 2023 09:15
Copy link
Contributor Author

renovate bot commented Dec 19, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 5.x releases. But if you manually upgrade to 5.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/actions-setup-python-5.x branch December 19, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant